• S
    Sebastian Gurgul

    Hi,

    I found that the TCP connection of Modbus4j does not fully support timeout features of Java sockets.

    Only the connection timeout is controlled in current implementation.
    It can be easily extended by controlling the read timeout too.

    For this reason one can consider changing TcpMaster.openConnection() method part:

    Before:

    socket = new Socket();
    socket.connect(new InetSocketAddress(ipParameters.getHost(), ipParameters.getPort()), getTimeout());
    transport = new StreamTransport(socket.getInputStream(), socket.getOutputStream());

    After:

    socket = new Socket();
    socket.setSoTimeout(getTimeout());
    socket.connect(new InetSocketAddress(ipParameters.getHost(), ipParameters.getPort()), getTimeout());
    transport = new StreamTransport(socket.getInputStream(), socket.getOutputStream());

    This might be useful for somebody.

    posted in Modbus4J general discussion read more
  • S
    Sebastian Gurgul

    Hi,

    I found that the TCP connection of Modbus4j does not fully support timeout features of Java sockets.

    Only the connection timeout is controlled in current implementation.
    It can be easily extended by controlling the read timeout too.

    For this reason one can consider changing TcpMaster.openConnection() method part:

    Before:

    socket = new Socket();
    socket.connect(new InetSocketAddress(ipParameters.getHost(), ipParameters.getPort()), getTimeout());
    transport = new StreamTransport(socket.getInputStream(), socket.getOutputStream());

    After:

    socket = new Socket();
    socket.setSoTimeout(getTimeout());
    socket.connect(new InetSocketAddress(ipParameters.getHost(), ipParameters.getPort()), getTimeout());
    transport = new StreamTransport(socket.getInputStream(), socket.getOutputStream());

    This might be useful for somebody.

    posted in Modbus4J general discussion read more